Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply consistent header to all pages #46

Merged
merged 8 commits into from
Dec 16, 2024
Merged

apply consistent header to all pages #46

merged 8 commits into from
Dec 16, 2024

Conversation

austensen
Copy link
Member

@austensen austensen commented Dec 16, 2024

Adds the new consistent header design for all pages.
Before we talked about maybe dropping the breadcrumbs, I already did some clean up of those to reduce repetition across pages.
Also show the result criteria table within header by default (no show/hide toggle)
I'll need to fix the print styles a bit after these changes, but going to do that as a separate PR.

[sc-15951]

@austensen austensen requested a review from kiwansim December 16, 2024 20:53
Base automatically changed from content-accordions to main December 16, 2024 21:29
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for gce-screener ready!

Name Link
🔨 Latest commit 1143e58
🔍 Latest deploy log https://app.netlify.com/sites/gce-screener/deploys/67609c414e91df00088e13b9
😎 Deploy Preview https://deploy-preview-46--gce-screener.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for gce-screener ready!

Name Link
🔨 Latest commit fa761ec
🔍 Latest deploy log https://app.netlify.com/sites/gce-screener/deploys/67609c6e00ac520008b5e656
😎 Deploy Preview https://deploy-preview-46--gce-screener.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kiwansim kiwansim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the header refactoring looks so much cleaner!!

@austensen austensen merged commit 2c38b22 into main Dec 16, 2024
4 checks passed
@austensen austensen deleted the headers branch December 16, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants