Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor results styles, update print styles, expand accordions #55

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

austensen
Copy link
Member

@austensen austensen commented Dec 18, 2024

Updates the styles for printing the results page (guide pages to follow in separate PR)

This ones has a lot of reorganization of styles (lots of moving around, and changed nested), and also some minor additions to component (eg. adding print dividers after content boxes) that created big diffs where there aren't real changes.

All closed accordions are automatically opened for the print and then reset back to preexisting state afterwards.

I had to make some changes from the design files to keep everything on the page. In particular, the text was too big on the print page, so I also changed the base font size when printing down to 12px and that helped. Will review with Corey, but good to merge this in first since there are so many changes it'll make it hard to do other things without lots of merge conflicts.

Here's an example of a print ed result: gce-result-print.pdf

might add page-break-after: always; on contentbox, waiting for corey feedback

[sc-15986]

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for gce-screener ready!

Name Link
🔨 Latest commit 403b7c8
🔍 Latest deploy log https://app.netlify.com/sites/gce-screener/deploys/6764581ea17806000883b53a
😎 Deploy Preview https://deploy-preview-55--gce-screener.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@austensen austensen marked this pull request as draft December 18, 2024 23:13
@austensen austensen requested a review from kiwansim December 19, 2024 17:34
@austensen austensen marked this pull request as ready for review December 19, 2024 17:34
@austensen austensen merged commit 5a00c6e into main Dec 20, 2024
4 checks passed
@austensen austensen deleted the results-print branch December 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants