Factor out a <LocaleLink> component. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
commented
Aug 13, 2020
| * the path! | ||
| */ | ||
| export function LocaleLink<TState>( | ||
| props: GatsbyLinkProps<TState> & { ref?: never } |
There was a problem hiding this comment.
I was having weird type issues with the ref prop but since we never actually use it in our code, I just simplified things by prohibiting it.
sraby
approved these changes
Aug 13, 2020
sraby
reviewed
Aug 13, 2020
Comment on lines
+47
to
+53
| content: { | ||
| title: string; | ||
| subtitle: string; | ||
| ctaLink: string; | ||
| ctaText: string; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I like this approach of slowly adding in more explicit type definitions as we go.
|
@toolness feel free to squash and merge when you get a chance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out a
<LocaleLink>component that automatically prefixes the passed-in URL with the current locale, as in WoW (see JustFixNYC/who-owns-what#186).