Use @justfixnyc/geosearch-requester #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to use @justfixnyc/geosearch-requester instead of
geo-autocomplete-base.tsx
.The tricky bit here is that
@justfixnyc
-scoped packages contain untranspiled ES6 code, so we need to make sure it all gets transpiled.This mostly went OK because Gatsby always transpiles
node_modules
during production (see gatsbyjs/gatsby#14111). However, it seems transpilation to ES5 is not occurring during development, because loading the site in IE11 during development results in a syntax error for an arrow function in@justfixnyc/geosearch-requester
--but building the site for production usingyarn build
and then viewing it in IE11 works fine. I'm not a fan of this, but I'm not sure if there's any way to easily fix it.Jest support had to be added using its
transformIgnorePatterns
configuration option.Additionally, I manually imported
whatwg-fetch
because its polyfill is needed for IE11.