Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @justfixnyc/geosearch-requester #40

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Use @justfixnyc/geosearch-requester #40

merged 2 commits into from
Oct 29, 2019

Conversation

toolness
Copy link
Contributor

This is an attempt to use @justfixnyc/geosearch-requester instead of geo-autocomplete-base.tsx.

The tricky bit here is that @justfixnyc-scoped packages contain untranspiled ES6 code, so we need to make sure it all gets transpiled.

This mostly went OK because Gatsby always transpiles node_modules during production (see gatsbyjs/gatsby#14111). However, it seems transpilation to ES5 is not occurring during development, because loading the site in IE11 during development results in a syntax error for an arrow function in @justfixnyc/geosearch-requester--but building the site for production using yarn build and then viewing it in IE11 works fine. I'm not a fan of this, but I'm not sure if there's any way to easily fix it.

Jest support had to be added using its transformIgnorePatterns configuration option.

Additionally, I manually imported whatwg-fetch because its polyfill is needed for IE11.

@sraby sraby merged commit 98b8dae into master Oct 29, 2019
@sraby
Copy link
Member

sraby commented Oct 29, 2019

thank you @toolness!

@sraby
Copy link
Member

sraby commented Oct 29, 2019

And arggg yes I noticed the odd error when trying to use Browserstack with my localhost... the good news is that the DDO dropdown is now indeed working on IE and we are able to test any pending changes with our Netlify preview link.

@sraby sraby deleted the geosearch-requester branch October 29, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants