Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all existing forms use the LegacyFormSubmitter or SessionUpdatingFormSubmitter #123

Closed
toolness opened this issue Sep 9, 2018 · 0 comments
Closed

Make all existing forms use the LegacyFormSubmitter or SessionUpdatingFormSubmitter #123

toolness opened this issue Sep 9, 2018 · 0 comments

Comments

@toolness
Copy link
Collaborator

toolness commented Sep 9, 2018 •
edited
Loading

We added support for legacy forms in #120 but none of the existing forms actually use it yet.

This will require fixing #121 too.

Update: At some point we added SessionUpdatingFormSubmitter which builds upon LegacyFormSubmitter , so we should use that where possible.
This was referenced Sep 12, 2018
Closed
Closed
@toolness toolness changed the title Make all existing forms use the LegacyFormSubmitter Make all existing forms use the LegacyFormSubmitter or SessionUpdatingFormSubmitter Sep 15, 2018
This was referenced Sep 15, 2018
Merged
Merged
toolness added a commit that referenced this issue Sep 16, 2018
@toolness
Use SessionUpdatingFormSubmitter everywhere. Fixes #123.
1546ce7
@toolness toolness mentioned this issue Sep 16, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toolness