Add new privacy and comms fields to OnboardingInfo model #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
added a commit
that referenced
this pull request
Apr 28, 2020
This adds two new mutations that build upon the database schema changes introduced in #1327: * A new `agreeToTerms` mutation allows the front-end to ask the user to agree to privacy policies from a site other than the one they originally signed up for. * A new `optInToRttcComms` mutation allows the front-end to ask the user if they would like to opt-in to communications from the Right to the City Alliance (RTTC).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new privacy and communications-related fields:
agreed_to_justfix_terms- Whether the user agreed to the JustFix.nyc TOS + privacy policy. This can only be true or false; if it's false, we basically shouldn't let them use JustFix.nyc until they agree to them. It defaults toTruefor all existing users in our database (since they can only be JustFix.nyc users, as we haven't launched NoRent.org yet, and they checked the checkbox when signing up); going forward, only users who onboard via JustFix.nyc will have this set toTrueupon signup (since they checked the checkbox).agreed_to_norent_terms- Whether the user agreed to the NoRent.org TOS + privacy policy. This can only be true or false; if it's false, we basically shouldn't let them use NoRent.org until they agree to them. Going forward, only users who onboard via NoRent.org will have this set toTrueupon signup (since they checked the checkbox).can_receive_rttc_comms- Whether the user explicitly agreed or disagreed to receiving communications from the Right to the City Alliance (RTTC). Note that aside fromTrueandFalse, this can also beNone(NULL in the database) to indicate that we haven't asked the user yet.This also adds accessors for the fields to our GraphQL schema, under the
session.onboardingInfofield. It does not yet add mutations to allow the front-end to change their values, that will be for a future commit.