Enable Django i18n of first-party strings. #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
commented
May 6, 2020
Comment on lines
+23
to
+26
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.fields['first_name'].required = True | ||
| self.fields['last_name'].required = True |
There was a problem hiding this comment.
Oops, this is unrelated to internationalization but I realized that we're not actually requiring this information in our form!
toolness
changed the title
toolness
changed the title
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables internationalization of Django strings and ensures that
compilemessagesis called prior to deployment.Unrelatedly, it also requires first and last name to be filled out in the NoRent.org onboarding flow (until now they were optional).