Add support for i18n in norent airtable. #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2020
toolness
added a commit
that referenced
this pull request
May 7, 2020
This loads the locale-specific national metadata bundle for the NoRent site, which exposes the NoRent localized airtable data on the front-end, completing the work started in #1392. As with the Lingui catalogs, we use code splitting to ensure that only the bundle for the current locale is retrieved. One unfortunate aspect of this approach to localizing our national metadata is that we've got a lot of data in the locale-specific bundles that isn't actually locale-specific, and that comes with a few wrinkles, which I've documented in #1401.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some plumbing for i18n to our code that pulls from the norent airtable. While it doesn't fully enable i18n in the app, it now knows to treat any field name that ends in " (English)" as being localized to
enand anything ending in " (Spanish)" as being localized ines. For instance, this is what our "State Legislation for Letter Builder Screens" table looks like now:At present the code in this PR is only paying attention to the English version, and it's generating the exact same JSON as it did before. This allows translators to start localizing the Airtable ASAP.
In a future commit, we'll create separate JSON files for each table in each language. Then we'll load the correct one at runtime.