Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize files in letter-builder directory. #1406

Merged
merged 5 commits into from
May 14, 2020

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented May 7, 2020

This internationalizes everything in the letter-builder directory.

@toolness toolness changed the title Internationalize letter-builder pages. Internationalize files in letter-builder directory. May 7, 2020
Copy link
Member

@sraby sraby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, Mr. Atul! I added a few comments in places where you missed adding internationalization, but only a small handful of those.

@sraby
Copy link
Member

sraby commented May 14, 2020

@toolness mind just pinging me when you go ahead and merge this one? I have a Clubhouse task that involves the letter builder welcome page that I'm going to try and work on as soon as this is merged in.

@toolness toolness merged commit cd811ae into master May 14, 2020
@toolness toolness deleted the i18n-letter-builder branch May 14, 2020 20:15
@toolness toolness mentioned this pull request May 14, 2020
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants