Add a --garble option to localebuilder. #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2020
toolness
added a commit
that referenced
this pull request
May 21, 2020
So #1468 only garbled lingui-generated PO files; this one adds support for garbling Django PO files too, while attempting to preserve gettext variables.
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well I probably shouldn't have done this, but I was so loathe to manually find un-internationalized text in our codebase that making this was more fun, so here we are.
When one runs
node localebuilder.js --garble, the non-English message catalogs will be replaced with "garbage" translations, which makes it easy to see what's not localized in the app. Here's a screenshot:Obviously the garbage translation should never actually be committed.
The tricky part about this was preserving Lingui's React tags and ICU MessageFormat syntax. While it's code that will only ever be used during development, the only reasonable way forward was by writing the tests first, and then making them pass (TDD).