Ensure FAQ questions are always internationalized #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
commented
May 21, 2020
Comment on lines
591
to
594
| const { previewOptions } = faq; | ||
| if (previewOptions) { | ||
| FaqsWithPreviewContent.push({ ...faq, previewOptions }); | ||
| } |
There was a problem hiding this comment.
Super weird that this appears to be the most TypeScript-friendly way to create this array. You'd think we could just say if (faq.previewOptions) FaqsWithPreviewContent.push(faq) but that doesn't work. 😞
toolness
changed the title
33 tasks
sraby
reviewed
May 21, 2020
Comment on lines
+598
to
+603
| results.sort( | ||
| (faq1, faq2) => | ||
| faq1.previewOptions.priorityInPreview - | ||
| faq2.previewOptions.priorityInPreview | ||
| ); | ||
|
|
There was a problem hiding this comment.
Nice, this is so much simpler to read!
sraby
approved these changes
May 21, 2020
|
Awesome, thanks Sam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While browsing the site with garbled translations active, I noticed that FAQ questions in the preview section weren't garbled:
It looks like this was happening because
li18n._()was being called in top-level module code infaqs-content.tsx, so I wrapped it all in a function.While I was at it, I also potentially simplified the sorting of the FAQs with preview content, I'm not sure though. I think code-wise it might be more code, but I think it's also potentially more readable. Feedback welcome @sraby!