Internationalize NoRent SMS message. #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
commented
May 27, 2020
| "This site is currently in <strong>compatibility mode</strong>. For an " | ||
| "enhanced experience, you can disable it, but this may cause compatibility " | ||
| "issues with your current browser." | ||
| msgid "This site is currently in <strong>compatibility mode</strong>. For an enhanced experience, you can disable it, but this may cause compatibility issues with your current browser." |
There was a problem hiding this comment.
Nothing actually changed here, it's just a result of using --no-wrap w/ Django's makemessages command... it doesn't do much this file (our English translations) but it helps the Spanish ones not be in a constant state of churn, where Crowdin writes them out without line wrapping in one PR and Django wraps them in another PR, making diffs more confusing (see ee71e2a for an example of the confusing behavior).
There was a problem hiding this comment.
Ahhh yeah I could imagine that getting frustrating!
33 tasks
sraby
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds
--no-wraptoyarn django:makemessagesto ensure that Crowdin and Django aren't fighting over line wrapping.