Redirect Spanish routes on JustFix.nyc to the English version. #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
sraby
reviewed
May 28, 2020
Comment on lines
+9
to
+13
| export function createLocaleRedirectorRoute( | ||
| from: LocaleChoice, | ||
| to: LocaleChoice | ||
| ): JSX.Element { | ||
| const fromPath = `/${from}/`; |
There was a problem hiding this comment.
Noice! This is super clear and unambiguous as to what this function is doing :)
sraby
approved these changes
May 28, 2020
|
Yup yup!!! For now it'll redirect everything on JustFix.nyc but in the future we can change it so it supports certain routes, etc. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463.
NoRent.org is localized but JustFix.nyc isn't; our server's locale negotiation logic doesn't know this, so it might send the user to the Spanish version of JustFix.nyc (e.g., from
/to/es/), and if that happens we want to redirect the user to the English version, since the Spanish version of JustFix.nyc isn't ready yet.We're just doing this on the client-side for now because we don't really know what our localization strategy will be for JustFix.nyc: one idea that's been floated is to actually localize our offerings product-by-product, e.g. localizing EHPA before LOC, which would mean we'd need to granualize this redirection based on knowledge of client-side routes, so the client-side seems the best place to put this logic for now.