Add a language toggle to NoRent. #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a language toggle to the footer of NoRent. I put it in the footer instead of the navbar because the navbar was becoming quite cluttered on desktop, and on mobile it'd be hidden behind a hamburger menu; it's also based on a similar placement on websites like mozilla.org.
It's not exactly highly visible but my hope is that Django's auto-redirection of browsers to the appropriate locale based on their language preferences will take care of sending most users to the appropriate locale. (That is, if a user's browser is in Spanish and they go to https://norent.org/, they will be transparently redirected to https://norent.org/es/.)
Furthermore, it seems like this kind of solution isn't necessarily mutually exclusive with putting some kind of UI at the top of the page: as with the navbar links, we can have them both at the header and footer.