Implement content for React-rendered LOC. #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
added a commit
that referenced
this pull request
Jun 10, 2020
This builds upon #1534 by rendering the React version of the LOC content from the user's session data and exposing it at `/loc/react-letter.pdf` (the `react-` prefix means it won't conflict with the Django-based renderer, which is still what's used in production).
This was referenced Jun 10, 2020
toolness
added a commit
that referenced
this pull request
Jun 11, 2020
In #1534 we removed the user's contact info from the end of their LOC, but forgot about the last paragraph of the letter, which refers to "the number provided below". This just replaces that text with the user's actual phone number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows-up on #1533 to implement the Letter of Complaint content in React. (We're still not actually rendering the letter we send in React yet, more needs to be done for that switchover to occur.)