Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry TextIt requests if needed. #1641

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Retry TextIt requests if needed. #1641

merged 2 commits into from
Aug 18, 2020

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented Aug 18, 2020

Fixes #1567 using a mechanism outlined in the Celery documentation on retrying tasks.

I originally used Celery's autoretry_for keyword argument here but it was impossible to test (or even to test that I wasn't misspelling autoretry_for, as renaming the argument to LOL resulted in everything still working) so I reverted to doing things the long way around. I'm still not particularly convinced this is a good test, or that the retry logic will even work in production, but whatever.

@toolness toolness merged commit 01e0634 into master Aug 18, 2020
@toolness toolness deleted the textit-500-handling branch August 18, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextIt API requests should retry if they get 500 errors
1 participant