Remove a bunch of long-deprecated GraphQL fields #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,21 +79,6 @@ class NorentScaffolding(pydantic.BaseModel): | |||
|
|
|||
| phone_number: str = "" | |||
|
|
|||
| landlord_name: str = "" | |||
There was a problem hiding this comment.
Oh good, these were always confusing to me
samaratrilling
approved these changes
Jul 9, 2021
|
🎉 At my old job we used to get a badge for deleting a certain number of lines of code. |
|
Heh nice, I like the idea of a badge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a bunch of GraphQL fields that have been deprecated for a long time:
stabilizedUnitCount2017, deprecated by Add 2019 Rent Stab data to Data Driven Onboarding #1690 in October 2020norentScaffoldingthat were deprecated before we even formally launched NoRent.org in Spring 2020.prefersLegacyApp, deprecated by Remove all code relating to the legacy tenant app. #1631 in August 2020. Fixes Remove deprecatedprefersLegacyAppGraphQL field #1632.