Geocoding validation #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses geosearch to attempt to validate the user's address in onboarding step 1.
If the geosearch service is unavailable for some reason, we note this by setting
address_verifiedtoFalsein the user's session, and allow them to continue onboarding, so the user isn't blocked from signing up.However, if geosearch is available and doesn't give us any results, we raise an error in the form.
If geosearch is available, and gives us results, we set the user's address in the form's
cleaned_data(and thus the user session) to the house number and street name of the first result.