Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user object condition #871

Closed
wants to merge 1 commit into from

Conversation

austensen
Copy link
Member

Found another case of conditioning on the user object that is now evaluating true when it's actually just the empty placeholder. This is another case of the issue fixed in #870 . It was causing the account settings page to appear but with all the user content missing. Now it correctly shows nothing, like before

@austensen austensen requested a review from kiwansim March 25, 2024 20:34
Copy link
Member

@kiwansim kiwansim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I register or login from the nav, the register/login call returns a 200 but the site shows a blank screen and the nav bar shows "Login" until I manually refresh.

did you see this happen on your local instance?

https://www.loom.com/share/f50fce9353fb453a92d1da7725355fc9

@austensen
Copy link
Member Author

After looking more closely I don't think this is actually causing the same kind of issue as the user object condition was on login. And once we implement the redirect based on on login status it would replace this condition anyway

@austensen austensen closed this Mar 26, 2024
@austensen austensen deleted the user-condition-bug branch March 26, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants