Add homebridge integration #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ballinc Thanks for your contribution! I'm currently not at home (until the 23th), but will look at it when I'm back. Initial thoughts are great though! 🙂 |
|
Hi @ballinc, I've done several refactors to improve the code. But generally it was pretty good already. |
JustJoostNL
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration option for Homebridge.
Homebridge must be running with -I option (insecure mode) for accessory control.
Currently only supports HSB accessories. I can't find any examples of any other type of colour mixing to try.
I think I've added it everywhere that is required, works well on my setup.