Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-zero delay between first attempt and first retry for linear and exp strategy #163

Commits on Aug 16, 2021

  1. tests: static backoff: check delay

    See issue JustinBeckwith#122.
    
    This is to confirm that the delay
    between the first (actual) attempt
    and the first retry is not zero,
    but the configured delay.
    
    tests: prettier format (noop)
    
    tests: prettier format (noop)
    jgehrcke committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    88261ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4173be View commit details
    Browse the repository at this point in the history
  3. calc delay: fix currentRetryAttempt mutation

    The mutation did not affect the code below.
    This is for issue JustinBeckwith#122.
    
    calc delay: prettier (format)
    jgehrcke committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    83f31bb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ba85b6 View commit details
    Browse the repository at this point in the history
  5. calc delay: mutate cfg on orig err obj

    Found that state is not retained across
    retries when mutating
    `config.currentRetryAttempt` here.
    jgehrcke committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    fd9857c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c059361 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. package.json: require nodejs 10.7.0 or newer

    This is to address the `gts fix` error
    
        The 'process.hrtime.bigint' is not supported
        until Node.js 10.7.0. The configured version
        range is '>=10.0.0'
    
    This function is only used in the test suite
    so maybe it's not the best solution to change
    the NodeJS version requirement for the
    entire package. However, whoever runs this on
    NodeJS older than 10.7.0 (released on
    2018-07-18) might want to be encouraged to
    use a more recent version.
    jgehrcke committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    141e76c View commit details
    Browse the repository at this point in the history