Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable maxRetryDelay #165

Merged
merged 2 commits into from
Aug 23, 2021
Merged

feat: configurable maxRetryDelay #165

merged 2 commits into from
Aug 23, 2021

Conversation

barrett-schonefeld
Copy link
Contributor

@barrett-schonefeld barrett-schonefeld commented Aug 23, 2021 •
edited
Loading

Implements #164

Changes:

  • Allows configurable, optional maxRetryDelay.
  • If provided, applies the maxRetryDelay when calculating the delay.

Tests:

  • Sets a short timeout and a high initial value for retryDelay such that the test will only pass if the maxRetryDelay is honored.

Question:

  • Currently, we apply the maxRetryDelay for linear, static, and exponential cases. Should we scope this to some subset of those?

@barrett-schonefeld barrett-schonefeld force-pushed the max-retry-delay branch 3 times, most recently from 1a74dfa to 9b7656e Compare August 23, 2021 15:38
JustinBeckwith
JustinBeckwith approved these changes Aug 23, 2021
View reviewed changes
Copy link
Owner

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a great test!

@JustinBeckwith
Copy link
Owner

And to the question - I think I'm fine having the max apply to all strategies.

@JustinBeckwith JustinBeckwith merged commit b8842d7 into JustinBeckwith:main Aug 23, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JustinBeckwith JustinBeckwith mentioned this pull request Aug 23, 2021
Closed
@barrett-schonefeld barrett-schonefeld deleted the max-retry-delay branch August 23, 2021 18:21
@barrett-schonefeld barrett-schonefeld mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrett-schonefeld @JustinBeckwith