fix: export the shouldRetryRequest method #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
requested changes
Jan 11, 2020
There was a problem hiding this comment.
Thanks for the feature! I am fine accepting the exported function, but would like to keep that separate from the other changes (which I honestly still don't understand). Could I trouble you to back those out?
It would also be rad to add a note about the method to the README!
JustinBeckwith
changed the title
JustinBeckwith
changed the title
|
Hi mate, I've removed the changes unrelated to |
JustinBeckwith
approved these changes
Oct 23, 2020
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make it available to use in my own
shouldRetryfunction, rather than duplicate too much logic. So I added 'export' to the function declaration, ran the tests and it all seems to work!Also included the fix for #1 that @opyate / @JustinBeckwith wrote. Hope that's okay. I just copied it into my fork so I could use the fix and couldn't be bothered removing it for this PR 😅