Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text on the dungeon teleports #38

Merged
merged 3 commits into from
Oct 20, 2024

Conversation

kayti-wow
Copy link
Contributor

Took a stab at implementing #10

There is a checkbox to turn it on and off in the options, but it needs a reload after changing the settings.

@kayti-wow
Copy link
Contributor Author

image

@Justw8
Copy link
Owner

Justw8 commented Oct 17, 2024

Thanks, I will look at this once I merge in #41 to make sure it's all set. Sorry for the delay!

@kayti-wow kayti-wow mentioned this pull request Oct 19, 2024
@Justw8
Copy link
Owner

Justw8 commented Oct 19, 2024

The seasonal flyout is merged, now, let me know if you want to update this (and perhaps re-work the list slightly to use isCurrentSeason) or if you want me to look at it and fix things up!

@kayti-wow
Copy link
Contributor Author

I'm taking a look now. I should be able to get something done soon

@kayti-wow
Copy link
Contributor Author

I think this can be merged as it is now and we can come back to refactor out the duplicated code in a different PR?

image

@Justw8
Copy link
Owner

Justw8 commented Oct 20, 2024

Yep, all good; will be doing a full refactor whenever I find some free time in the future anyways, this'll do for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants