Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reverse flyout buttons #43

Closed
wants to merge 2 commits into from

Conversation

EraxterCodes
Copy link
Contributor

@EraxterCodes EraxterCodes commented Oct 13, 2024

I use this addon a lot as a mage to create portals for group members at end of dungeons however since mages know a lot of portals and dornogal is that last one of the list you have to be careful with moving the mouse when in hurry. As dornogal is the most common portal I added the option to reverse the order of the flyouts so it appears first.

image

I toyed a little with making it not require a /reload after changing the settings but never got it to work. If this is something you are interested in pulling into main just let me know and I can update the pull request before merging to include this behavior. I didn't toy with it too long as I doubt I will ever want it switched off.

@Justw8
Copy link
Owner

Justw8 commented Oct 17, 2024

This PR has become a bigger change than initially meant for I think?

could you revert and only include the reverse flyout options settings? The seasonal stuff will be covered in the other PR #41

@EraxterCodes
Copy link
Contributor Author

This PR has become a bigger change than initially meant for I think?

could you revert and only include the reverse flyout options settings? The seasonal stuff will be covered in the other PR #41

Yes my mistake i was playing around and forgot to revert my push to Remote… I am away for the weekend without access to a PC/laptop but I will revert on Monday apologies for any inconvenience

@Justw8
Copy link
Owner

Justw8 commented Oct 19, 2024

Bump on this, will also need conflict resolved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants