-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor forward/backwards loop #54
Conversation
I wanted to do that, but saw subtype wasn't passed on yet. should just pass the full flyout information as table and not seperate arguments though. |
let me merge the two prs and cleanup passing the flyout info 👍 |
All the comments confuse me - usually the author himself isn't the one doing this. Could you do whatever you want from the comments, and then I can review/merge the final changes? |
Reviews are a two way street? :) This way I can communicate my thoughts 😅 |
@Justw8 Ready for review |
@Justw8 FYI you can turn off comments in the file review: I personally use the GitHub PR review as it shows the code differently than in the editor and I am usually able to catch mistake. |
we could add a
subtype = "mage"
to simplify theflyoutId == 1 or flyoutId == 8 or flyoutId == 11 or flyoutId == 12
😅