Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor forward/backwards loop #54

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Conversation

jetersen
Copy link
Contributor

we could add a subtype = "mage" to simplify the flyoutId == 1 or flyoutId == 8 or flyoutId == 11 or flyoutId == 12 😅

@Justw8
Copy link
Owner

Justw8 commented Oct 22, 2024

I wanted to do that, but saw subtype wasn't passed on yet. should just pass the full flyout information as table and not seperate arguments though.

@jetersen
Copy link
Contributor Author

let me merge the two prs and cleanup passing the flyout info 👍

@jetersen jetersen mentioned this pull request Oct 22, 2024
TeleportMenu.lua Outdated Show resolved Hide resolved
TeleportMenu.lua Outdated Show resolved Hide resolved
TeleportMenu.lua Outdated Show resolved Hide resolved
@Justw8
Copy link
Owner

Justw8 commented Oct 23, 2024

All the comments confuse me - usually the author himself isn't the one doing this.

Could you do whatever you want from the comments, and then I can review/merge the final changes?
And since I merged the locale PR there's a conflict that needs fixing too.

@jetersen
Copy link
Contributor Author

Reviews are a two way street? :) This way I can communicate my thoughts 😅

@jetersen
Copy link
Contributor Author

@Justw8 Ready for review

@jetersen
Copy link
Contributor Author

@Justw8 FYI you can turn off comments in the file review:
image

I personally use the GitHub PR review as it shows the code differently than in the editor and I am usually able to catch mistake.

@Justw8 Justw8 merged commit a79765a into Justw8:main Oct 24, 2024
@jetersen jetersen deleted the fix/forwardbackwardloop branch October 25, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants