Some docs fixes #103
Merged
Some docs fixes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 42 42
Lines 5565 5565
=======================================
Hits 4530 4530
Misses 1035 1035 ☔ View full report in Codecov by Sentry. |
Jutho
reviewed
Feb 2, 2024
Jutho
reviewed
Feb 2, 2024
|
Thanks. Looks good, up to one comment. |
|
Also snuck in a small typo fix in the Deligne product docstring while I"m at it. |
lkdvos
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for docstrings that appeared as missing in
lib/tensors. Some of them were actually missing and I only added the ones I was confident about adding, and some of them weren't appearing because they were already referenced somewhere else so I had to mess with the type specifiers a bit.The only thing here I'm not too sure about are the references to
blocksectorsinlib/spaces. I found two relevant documented methods so I added these both explicitly, but it feels like maybe there should just be one docstring for an overarchingblocksectors(::VectorSpace)?