This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Remove Messenger actor and use withContext instead #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
force-pushed
the
travis/shoot-the-messenger
branch
from
June 26, 2019 05:51
edef027
to
36f763a
Compare
twyatt
force-pushed
the
travis/shoot-the-messenger
branch
2 times, most recently
from
April 5, 2020 03:19
d1e2203
to
635f9b0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #31 +/- ##
==============================================
+ Coverage 20.37% 74.38% +54.00%
- Complexity 17 35 +18
==============================================
Files 14 14
Lines 476 242 -234
Branches 42 28 -14
==============================================
+ Hits 97 180 +83
+ Misses 368 52 -316
+ Partials 11 10 -1
|
twyatt
force-pushed
the
travis/shoot-the-messenger
branch
15 times, most recently
from
April 7, 2020 20:36
7b04eea
to
8bfe1c0
Compare
Inspired by [comment] by elizarov (on Jun 15) in Kotlin/kotlinx.coroutines#87: > when you ask and actor and want a result back the proper design would > be to have a `suspend fun` with a normal (non-deferred) `Result`. > However, please note that this whole ask & wait pattern is an > anti-pattern in actor-based systems, since it limits scalability. [comment]: Kotlin/kotlinx.coroutines#87 (comment)
twyatt
force-pushed
the
travis/shoot-the-messenger
branch
from
April 7, 2020 22:37
8bfe1c0
to
ca93d7b
Compare
Just want to make sure close wasn't already closed, as that would make the close call check later useless.
Chris-Corea
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, dude. Holy moly.
davidtaylor-juul
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 and tests 💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by comment by elizarov (on Jun 15) in Kotlin/kotlinx.coroutines#87:
Additionally, changing over to using
withContext
made the library much easier to write tests for.Took the refactor opportunity to:
Flow
for data streamsexperimental
from package name (since we're no longer using experimental Coroutines)