Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add OnServicesDiscovered event #52

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Apr 11, 2020

Encapsulates the service discovery response in OnServicesDiscovered event class, making it consistent with how other events are propagated.

Improves the logging of the event (in CoroutinesGatt.performBluetoothAction). Prior to this change the response was logged as:

I/Able: onServicesDiscovered ← 0

By wrapping in event class, log will now appear as:

I/Able: onServicesDiscovered ← OnServicesDiscovered(status=GATT_SUCCESS(0))

@twyatt twyatt marked this pull request as ready for review April 11, 2020 20:55
@twyatt twyatt added this to the 1.0.0 milestone Apr 11, 2020
@twyatt twyatt force-pushed the twyatt/OnServicesDiscovered branch from 0b6f1c5 to 88f20fd Compare April 15, 2020 03:11
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #52 into develop will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #52      +/-   ##
=============================================
+ Coverage      76.22%   76.51%   +0.28%     
  Complexity        35       35              
=============================================
  Files             12       12              
  Lines            244      247       +3     
  Branches          26       26              
=============================================
+ Hits             186      189       +3     
  Misses            50       50              
  Partials           8        8              
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/gatt/CoroutinesGatt.kt 50.00% <100.00%> (+1.28%) 10.00 <1.00> (ø)
core/src/main/java/gatt/Events.kt 72.85% <100.00%> (+1.21%) 0.00 <0.00> (ø)
core/src/main/java/gatt/GattCallback.kt 83.78% <100.00%> (-0.43%) 17.00 <1.00> (ø)

@twyatt twyatt merged commit d532e49 into develop Apr 15, 2020
@twyatt twyatt deleted the twyatt/OnServicesDiscovered branch April 15, 2020 03:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants