This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Drop ExperimentalCoroutinesApi annotation in GattCallback #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `GattCallback` in an `internal` class, it's properties are not part of the public API, so using `@ExperimentalCoroutinesApi` is superfluous.
Codecov Report
@@ Coverage Diff @@
## develop #54 +/- ##
==========================================
Coverage 74.89% 74.89%
Complexity 36 36
==========================================
Files 14 14
Lines 243 243
Branches 26 26
==========================================
Hits 182 182
Misses 53 53
Partials 8 8
|
davidtaylor-juul
approved these changes
Apr 14, 2020
Chris-Corea
approved these changes
Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
GattCallbackin aninternalclass, it's properties are not part of the public API, so using@ExperimentalCoroutinesApiis superfluous.