This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
force-pushed
the
twyatt/keep-alive
branch
from
April 28, 2020 20:05
98fe063
to
8969da6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #63 +/- ##
=============================================
+ Coverage 80.70% 83.13% +2.42%
- Complexity 36 55 +19
=============================================
Files 13 14 +1
Lines 254 338 +84
Branches 26 32 +6
=============================================
+ Hits 205 281 +76
- Misses 42 48 +6
- Partials 7 9 +2
|
twyatt
force-pushed
the
twyatt/keep-alive
branch
2 times, most recently
from
May 21, 2020 08:48
ee29e2d
to
a07a298
Compare
Determined that `BluetoothDevice.connectGatt` can return `null` when BLE is turned off, so settling on `Disconnected`, as caller should be able to try to reconnect again. Renamed `Closed` to `Cancelled` to align with function names that induce the state (`cancel` and `cancelAndJoin`).
Chris-Corea
approved these changes
May 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
keep-alive
module which provides aGattIo
implementation that reconnects when connection is lost.Rendered markdown documentation can be found here.