Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add keep-alive module #63

Merged
merged 15 commits into from
May 26, 2020
Merged

Add keep-alive module #63

merged 15 commits into from
May 26, 2020

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Apr 28, 2020

Adds keep-alive module which provides a GattIo implementation that reconnects when connection is lost.

Rendered markdown documentation can be found here.

@twyatt twyatt added this to the 1.0.0 milestone Apr 28, 2020
@twyatt twyatt force-pushed the twyatt/keep-alive branch from 98fe063 to 8969da6 Compare April 28, 2020 20:05
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #63 into develop will increase coverage by 2.42%.
The diff coverage is 90.47%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #63      +/-   ##
=============================================
+ Coverage      80.70%   83.13%   +2.42%     
- Complexity        36       55      +19     
=============================================
  Files             13       14       +1     
  Lines            254      338      +84     
  Branches          26       32       +6     
=============================================
+ Hits             205      281      +76     
- Misses            42       48       +6     
- Partials           7        9       +2     
Impacted Files Coverage Δ Complexity Δ
keep-alive/src/main/java/KeepAliveGatt.kt 90.47% <90.47%> (ø) 19.00 <19.00> (?)

@twyatt twyatt force-pushed the twyatt/keep-alive branch from b65308c to d9f3096 Compare May 13, 2020 07:33
@twyatt twyatt force-pushed the twyatt/keep-alive branch 2 times, most recently from ee29e2d to a07a298 Compare May 21, 2020 08:48
@twyatt twyatt force-pushed the twyatt/keep-alive branch from a07a298 to 3e899cb Compare May 21, 2020 17:06
@twyatt twyatt marked this pull request as ready for review May 22, 2020 08:37
@twyatt twyatt force-pushed the twyatt/keep-alive branch from 04d625d to 50e1889 Compare May 23, 2020 02:44
Determined that `BluetoothDevice.connectGatt` can return `null` when BLE
is turned off, so settling on `Disconnected`, as caller should be able
to try to reconnect again.

Renamed `Closed` to `Cancelled` to align with function names that induce
the state (`cancel` and `cancelAndJoin`).
@twyatt twyatt force-pushed the twyatt/keep-alive branch from 439ca46 to 45c12e3 Compare May 24, 2020 23:09
@twyatt twyatt force-pushed the twyatt/keep-alive branch from fa1430e to a6e2293 Compare May 25, 2020 06:57
Copy link

@Chris-Corea Chris-Corea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@twyatt twyatt merged commit 11d932f into develop May 26, 2020
@twyatt twyatt deleted the twyatt/keep-alive branch May 26, 2020 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants