Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Mark logger functions internal #68

Closed
wants to merge 1 commit into from
Closed

Mark logger functions internal #68

wants to merge 1 commit into from

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented May 27, 2020

Overlooked these being on the public API.
Caught it when running ./gradlew apiDump in #56.

@twyatt twyatt added this to the 1.0.0 milestone May 27, 2020
@twyatt twyatt marked this pull request as draft May 27, 2020 23:30
@twyatt
Copy link
Member Author

twyatt commented May 28, 2020

Unfortunately going to abandon this change.
The logging is useful from other modules (namely keep-alive at this point).

Ideally we'd expose the internal logger functions to the keep-alive module via friend-paths but I could not find relevant documentation, and was unable to get it working through trial-and-error.

It's a minor issue to expose the logger functions on the public API. If someone has insight into the friend-paths into how to get it working then it'd be great to re-tackle this.

Referenced the following issues for my attempts at getting friend-paths working:

@twyatt twyatt closed this May 28, 2020
@twyatt twyatt added the help wanted Extra attention is needed label May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant