This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
KeepAliveGatt EventHandler #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this API to set lambdas to be ran either onConnect or onDisconnect events
twyatt
reviewed
Jul 9, 2020
|
Unfortunately Android Studio and Kotlinter do not agree on import ordering. I think JetBrains has a fix coming so Android Studio can play nicer with Kotlinter. Until then, I've opted to have Kotlinter enforce it's import ordering. It's slightly cumbersome but at least makes ordering enforceable by CI. So you'll have to run |
twyatt
requested review from
austinhobbs,
cedrickcooke,
Chris-Corea,
KVelasco and
QuantumRand
Chris-Corea
reviewed
Jul 10, 2020
Chris-Corea
approved these changes
Jul 10, 2020
twyatt
reviewed
Jul 11, 2020
twyatt
reviewed
Jul 13, 2020
twyatt
reviewed
Jul 14, 2020
sdonn3
commented
Jul 15, 2020
| * @return `true` if connection was established (then dropped), or `false` if connection attempt failed. | ||
| * @throws ConnectionRejected if the operating system rejects the connection request. | ||
| */ | ||
| private suspend fun establishConnection(): Boolean { |
There was a problem hiding this comment.
I like this new naming way better
twyatt
reviewed
Jul 16, 2020
|
@Chris-Corea re-requested your review as we had to make substantial changes since you reviewed. |
Chris-Corea
approved these changes
Jul 16, 2020
twyatt
approved these changes
Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the consumer of this API to provide lambdas to run on either connection or disconnection events.
Rendered markdown of the updated documentation re:
Events is available here.