Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Add requestConnectionPriority #95

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Dec 4, 2020

Fixes #94

@twyatt twyatt force-pushed the twyatt/requestConnectionPriority branch from 4f1a055 to fe8b777 Compare December 4, 2020 06:14
@twyatt twyatt changed the base branch from main to develop December 4, 2020 06:16
@twyatt twyatt marked this pull request as ready for review December 4, 2020 06:19
@twyatt twyatt requested review from a team, QuantumRand and cedrickcooke December 4, 2020 06:19
@@ -44,6 +44,10 @@ class CoroutinesGatt internal constructor(
override val services: List<BluetoothGattService> get() = bluetoothGatt.services
override fun getService(uuid: UUID): BluetoothGattService? = bluetoothGatt.getService(uuid)

override fun requestConnectionPriority(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we treat them differently internally? Is this a bluetooth concept or just one within our stack?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we treat them differently internally?

What are you referring to when you say "them"?

Is this a bluetooth concept or just one within our stack?

It is a BLE concept. Has to do with how active the radios are for communication. Android sends a request to the remote peripheral to adjust its communication parameters.

@twyatt twyatt merged commit a28bde0 into develop Dec 15, 2020
@twyatt twyatt deleted the twyatt/requestConnectionPriority branch December 15, 2020 19:39
@twyatt twyatt added this to the 0.8.1 milestone Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants