This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add requestConnectionPriority #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
force-pushed
the
twyatt/requestConnectionPriority
branch
from
4f1a055 to
fe8b777
Compare
sdonn3
reviewed
Dec 4, 2020
| @@ -44,6 +44,10 @@ class CoroutinesGatt internal constructor( | |||
| override val services: List<BluetoothGattService> get() = bluetoothGatt.services | |||
| override fun getService(uuid: UUID): BluetoothGattService? = bluetoothGatt.getService(uuid) | |||
|
|
|||
| override fun requestConnectionPriority( | |||
There was a problem hiding this comment.
How do we treat them differently internally? Is this a bluetooth concept or just one within our stack?
There was a problem hiding this comment.
How do we treat them differently internally?
What are you referring to when you say "them"?
Is this a bluetooth concept or just one within our stack?
It is a BLE concept. Has to do with how active the radios are for communication. Android sends a request to the remote peripheral to adjust its communication parameters.
sdonn3
approved these changes
Dec 4, 2020
cedrickcooke
approved these changes
Dec 4, 2020
QuantumRand
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94