Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fails for external contributions #529

Closed
twyatt opened this issue Jul 12, 2023 · 0 comments · Fixed by #530
Closed

CI fails for external contributions #529

twyatt opened this issue Jul 12, 2023 · 0 comments · Fixed by #530

Comments

@twyatt
Copy link
Member

twyatt commented Jul 12, 2023

In #498 I simplified the Gradle scripts and wrongly assumed that if: github.repository_owner == 'JuulLabs' would cause CI steps to be skipped for PRs created from external repositories (#498 made it so that local Maven publish always tried to sign the publication with secrets only available under the JuulLabs GitHub org).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only sign local Maven publication on merges to main JuulLabs/kable
1 participant
@twyatt