Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only sign local Maven publication on merges to main #530

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jul 12, 2023

Performs publication signing for local Maven publication only for commits on main. This should allow external contributions to run local Maven publications w/o signing and once merged to main will validate that publication signing is configured properly.

Closes #529

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Jul 12, 2023
@twyatt twyatt requested a review from a team as a code owner July 12, 2023 17:36
@twyatt twyatt requested review from sdonn3 and davertay-j July 12, 2023 17:36
@twyatt twyatt force-pushed the twyatt/ci/signing branch 2 times, most recently from b5979c7 to 81b824a Compare July 12, 2023 17:43
@twyatt twyatt enabled auto-merge (squash) July 12, 2023 17:46
@twyatt twyatt disabled auto-merge July 12, 2023 17:48
@twyatt twyatt force-pushed the twyatt/ci/signing branch from 81b824a to 487b5c5 Compare July 12, 2023 17:50
@twyatt twyatt enabled auto-merge (squash) July 12, 2023 17:52
@twyatt twyatt merged commit e6f71ca into main Jul 12, 2023
@twyatt twyatt deleted the twyatt/ci/signing branch July 12, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails for external contributions
3 participants