Update plugin kotlin-multiplatform to v1.6.20 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: prior to merge, test compilation on Apple silicon. |
twyatt
force-pushed
the
renovate/org.jetbrains.kotlin.multiplatform-1.x
branch
from
8d15f36 to
9f94450
Compare
cedrickcooke
approved these changes
Apr 4, 2022
twyatt
reviewed
Apr 4, 2022
Comment on lines
-1
to
-3
| # https://kotlinlang.org/docs/mpp-share-on-platforms.html | ||
| kotlin.mpp.enableGranularSourceSetsMetadata=true | ||
| kotlin.native.enableDependencyPropagation=false |
There was a problem hiding this comment.
These removed options are deprecated in Kotlin 1.6.20 per release announcement.
twyatt
reviewed
Apr 4, 2022
Comment on lines
-39
to
-43
| // Workaround for https://youtrack.jetbrains.com/issue/KT-49109 that allows building on Apple Silicon | ||
| // This should no longer be needed with Kotlin version 1.6.20 | ||
| rootProject.plugins.withType<org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootPlugin> { | ||
| rootProject.the<org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension>().nodeVersion = "16.0.0" | ||
| } |
There was a problem hiding this comment.
Node.js 16.x.x should be default for Kotlin 1.6.20, so this workaround should no longer be needed.
sdonn3
approved these changes
Apr 4, 2022
|
@QuantumRand can you confirm that this builds on Apple silicon? |
No issues building on M1 🚀 |
QuantumRand
approved these changes
Apr 9, 2022
twyatt
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.6.10->1.6.20Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.