Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant logging of peripheral identifier #502

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jun 13, 2023

Example logs (from SensorTag sample app) shown with the redundant identifier (that this PR removes):

Screenshot 2023-06-13 at 10 43 04 AM

This occurs because loggers are already configured to log the identifier:

private val logger = Logger(logging, tag = "Kable/Delegate", identifier = identifier)

@twyatt twyatt added apple patch Changes that should bump the PATCH version number labels Jun 13, 2023
@twyatt twyatt marked this pull request as ready for review June 13, 2023 17:45
@twyatt twyatt requested review from a team and davertay-j as code owners June 13, 2023 17:45
@twyatt twyatt requested a review from cedrickcooke June 13, 2023 17:45
@twyatt twyatt enabled auto-merge (squash) June 13, 2023 17:47
@twyatt twyatt merged commit b07b570 into main Jun 15, 2023
@twyatt twyatt deleted the twyatt/logging-peripheral-identifier branch June 15, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple patch Changes that should bump the PATCH version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants