Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote identifier to property on Peripheral interface #509

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Promote identifier to property on Peripheral interface #509

merged 3 commits into from
Jun 26, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jun 21, 2023

Closes #508.

@twyatt twyatt added this to the 0.25.0 milestone Jun 21, 2023
@twyatt twyatt added the major Changes that should bump the MAJOR version number label Jun 21, 2023
@twyatt twyatt marked this pull request as ready for review June 21, 2023 07:22
@twyatt twyatt requested review from a team and davertay-j as code owners June 21, 2023 07:22
@twyatt twyatt requested a review from cedrickcooke June 21, 2023 07:22
@twyatt twyatt mentioned this pull request Jun 22, 2023
Closed
@twyatt twyatt enabled auto-merge (squash) June 26, 2023 21:29
@twyatt twyatt merged commit 9fe4bb8 into main Jun 26, 2023
@twyatt twyatt deleted the twyatt/peripheral-idenifier branch June 26, 2023 21:44
@twyatt twyatt mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedrickcooke cedrickcooke cedrickcooke approved these changes

@davertay-j davertay-j davertay-j approved these changes

Assignees
No one assigned
Labels
major Changes that should bump the MAJOR version number
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Cast exception when using Peripheral.identifier when extending AndroidPeripheral for testing
3 participants
@twyatt @cedrickcooke @davertay-j