Provide ability to pre-conflate scanned advertisements #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
approved these changes
May 27, 2024
|
@djweber Looks great! I added commits to your branch with some small changes. Thanks for the contribution! I'll merge after I get another PR approval. |
twyatt
changed the title
preConflate option for Scanner
twyatt
changed the title
preConflate option for Scanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed in #654 that using the default blocking send under certain conditions on various devices could result in ANRs being triggered when performing scans. This PR provides a way for users to opt in to make the Android scanner's
callbackFlowuse a non-blockingtrySendinstead oftrySendBlocking, with no change to the existing behavior.Closes #654