Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have allowDuplicateKeys default to true #760

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Sep 23, 2024

Change the default to match Android's behavior (the intention is that Kable out-of-the-box/with defaults, should give as consistent behavior as possible across platforms).

Without this change (with allowDuplicateKeys using Core Bluetooth's default, which is false) only 1 or 2 advertisement events are received during a scan, and doesn't give the feel of a "realtime" scan (with RSSI value, etc updating while scanning).

The drawback to this, is that Core Bluetooth documentation warns:

Disabling this filtering can have an adverse effect on battery life; use it only if necessary.

Kable consumers will need to explicitly set allowDuplicateKeys to false to get the default Core Bluetooth behavior.

@twyatt twyatt added apple major Changes that should bump the MAJOR version number labels Sep 23, 2024
@twyatt twyatt added this to the 0.35.0 milestone Sep 23, 2024
@twyatt twyatt marked this pull request as ready for review September 23, 2024 19:05
@twyatt twyatt requested a review from a team as a code owner September 23, 2024 19:05
@twyatt twyatt enabled auto-merge (squash) October 2, 2024 19:58
@twyatt twyatt merged commit 96f0243 into main Oct 2, 2024
2 checks passed
@twyatt twyatt deleted the twyatt/apple/allowDuplicateKeys branch October 2, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple major Changes that should bump the MAJOR version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants