Have allowDuplicateKeys
default to true
#760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default to match Android's behavior (the intention is that Kable out-of-the-box/with defaults, should give as consistent behavior as possible across platforms).
Without this change (with
allowDuplicateKeys
using Core Bluetooth's default, which isfalse
) only 1 or 2 advertisement events are received during a scan, and doesn't give the feel of a "realtime" scan (with RSSI value, etc updating while scanning).The drawback to this, is that Core Bluetooth documentation warns:
Kable consumers will need to explicitly set
allowDuplicateKeys
tofalse
to get the default Core Bluetooth behavior.