Skip to content

Commit

Permalink
Fixed Min Bed Temp
Browse files Browse the repository at this point in the history
  • Loading branch information
@Jyers
Jyers committed Apr 11, 2021
1 parent 43f14a2 commit b61f92a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Marlin/src/lcd/extui/lib/creality_dwin/creality_dwin.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,13 @@
#define MAX_FLOW_RATE 200
#define MIN_FLOW_RATE 10

#define MAX_E_TEMP (HEATER_0_MAXTEMP - (HOTEND_OVERSHOOT))
#define MIN_E_TEMP HEATER_0_MINTEMP
#define MAX_E_TEMP (HEATER_0_MAXTEMP - HOTEND_OVERSHOOT)
#define MIN_E_TEMP 0
#endif

#if HAS_HEATED_BED
#define MAX_BED_TEMP BED_MAXTEMP
#define MIN_BED_TEMP BED_MINTEMP
#define MIN_BED_TEMP 0
#endif

constexpr uint16_t TROWS = 6, MROWS = TROWS - 1,
Expand Down

9 comments on commit b61f92a

@aryajuanda
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not set BED_MINTEMP and HEATER_0_MINTEMP in Configuration.h ? the different in version 1.2.2 and 1.3.0 is in that file

just like #define MEATPACK_ON_SERIAL_PORT_1 on Configuration_adv.h that effect the octoprint connectivity issue (serial missmatch)

@Jyers
Copy link
Owner Author

@Jyers Jyers commented on b61f92a Apr 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryajuanda The bed and heater mintemp options should not be 0. They are meant to be a low range so the printer can detect a thermister failure. Also #define MEATPACK_ON_SERIAL_PORT_1 is required for meatpack support, so a fix that does not simply disable that functionality would be ideal.

@aryajuanda
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryajuanda The bed and heater mintemp options should not be 0. They are meant to be a low range so the printer can detect a thermister failure. Also #define MEATPACK_ON_SERIAL_PORT_1 is required for meatpack support, so a fix that does not simply disable that functionality would be ideal.

The meatpack is required for some one who use the meatpack plugin.. but for everyone else it not a requirement.. in my opinion its an optional to enable it..
but i know it also a bug in upsteam marlin to.. maybe it should be disable until fixed in uptream brach.. in my opinion..

@Jyers
Copy link
Owner Author

@Jyers Jyers commented on b61f92a Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryajuanda I don't believe the meatpack is the root of all the connectivity issues. I agree it may create some inconsistency at the moment, but I have tried both with and without the plugin installed and I am able to connect either way. Albeit it does take two attempts occasionally.

@aryajuanda
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it just in my setup.. i need to restart both octoprint and the printer to enable reconection... only on a cold start its not an issue... my raspberry is on for 24/7 but not my printer... after i turn off my printer i cant connect to octoprint on next start.. serial missmatch....i have to restart octoprint server or replug the usb..

@Jyers
Copy link
Owner Author

@Jyers Jyers commented on b61f92a Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the discussion on the issue with some information we have gathered. There is also a solution to should prevent the need to restart.

@tubalainen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryajuanda I don't believe the meatpack is the root of all the connectivity issues. I agree it may create some inconsistency at the moment, but I have tried both with and without the plugin installed and I am able to connect either way. Albeit it does take two attempts occasionally.

I beg to differ - I am using your code (thanks! <3 ) as a baseline but make my own alternations to suit my printer setup.
With the meatpack enabled in the FW the octoprint connection was VERY unreliable and gave Octoprint quite a number of errors when trying to connect - without the meatpack installed on Octoprint.

After I disabled the meatpack option it all went back to normal. - Personally I am using Arc welder and it also does compression so for me the meatpack option does only introduce more complexity.

Its your repository @Jyers and I respect your decision on adding it as a default option. But for the majority of your new user base the meatpack will just cause issues hence they are not using it.

@aryajuanda
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the latest MarlinFirmware Configuration example i see that Meatpack is disabled by default..

https://github.com/MarlinFirmware/Configurations/blob/232e16029a937b6912e5b9674840163b21c73f87/config/examples/Creality/Ender-3%20V2/Configuration_adv.h#L3405

i respect your decision to make it enable by default. i guess i will manually disable it when compiling... thank you...

@tubalainen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the latest MarlinFirmware Configuration example i see that Meatpack is disabled by default..

https://github.com/MarlinFirmware/Configurations/blob/232e16029a937b6912e5b9674840163b21c73f87/config/examples/Creality/Ender-3%20V2/Configuration_adv.h#L3405

i respect your decision to make it enable by default. i guess i will manually disable it when compiling... thank you...

The "default E3V2 config" yes - its untouched from Marlin(?).
But all the rest under "E3V2 templates" got the meatpack enabled by default - as well as the precompiled ones in the release.
https://github.com/Jyers/Marlin/blame/2c35946a0b65f72ce1716ed02cda87188d470184/Configuration%20Files/E3V2%20Templates/BLTouch-3x3-HighSpeed/Configuration_adv.h

Please sign in to comment.