Remove redundant alert name assignment

Removed the redundant line where alert name was being assigned with the Builder title in both graph.go and timeseries.go. Also updated the alert creation test in alert_test.go to reflect this change.
K-Phoen · Apr 30, 2024 · 2e021d1 · 2e021d1
1 parent eda0f96
commit 2e021d1
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/decoder/alert_test.go b/decoder/alert_test.go
@@ -32,7 +32,7 @@ func TestDecodingSimpleAlert(t *testing.T) {
 	opts, err := alertDef.toOptions()
 	req.NoError(err)
 
-	alertBuilder := alert.New("", opts...)
+	alertBuilder := alert.New("", "", opts...)
 	rule := alertBuilder.Builder.Rules[0]
 
 	req.Equal("description", rule.Annotations["description"])

diff --git a/graph/graph.go b/graph/graph.go
@@ -267,7 +267,6 @@ func XAxis(opts ...axis.Option) Option {
 func Alert(name string, opts ...alert.Option) Option {
 	return func(graph *Graph) error {
 		al := alert.New(name, graph.Builder.Title, opts...)
-		al.Builder.Name = graph.Builder.Title
 		graph.Alerts = append(graph.Alerts, al)
 
 		return nil

diff --git a/timeseries/timeseries.go b/timeseries/timeseries.go
@@ -410,7 +410,6 @@ func Transparent() Option {
 func Alert(name string, opts ...alert.Option) Option {
 	return func(timeseries *TimeSeries) error {
 		al := alert.New(name, timeseries.Builder.Title, opts...)
-		al.Builder.Name = timeseries.Builder.Title
 		timeseries.Alerts = append(timeseries.Alerts, al)
 
 		return nil