Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

009137 '*' on skvh for ClusterFilterSnapshot does not work #308

Open
c-bik opened this issue Jan 8, 2020 · 2 comments
Open

009137 '*' on skvh for ClusterFilterSnapshot does not work #308

c-bik opened this issue Jan 8, 2020 · 2 comments
Assignees
@piosok
Labels
bug

Comments

@c-bik
Copy link
Member

c-bik commented Jan 8, 2020

No description provided.

@c-bik c-bik added the bug label Jan 8, 2020
@c-bik c-bik self-assigned this Jan 8, 2020
piosok added a commit to piosok/imem that referenced this issue Jan 16, 2020
@piosok
K2InformaticsGmbH#308
c202cd0 
'*' is not interpreted as wildcard becuse only symbols in list are considered wildcards.
added clause hasWild to interpret '*' as wildcard too.
@piosok
Copy link
Contributor

piosok commented Jan 16, 2020

Please review the fix.

@piosok piosok mentioned this issue Jan 16, 2020
Closed
@c-bik
Copy link
Member Author

c-bik commented Jan 16, 2020

Please review the fix.

#313 (review)

@c-bik c-bik assigned piosok and unassigned c-bik Jan 16, 2020
piosok added a commit to piosok/imem that referenced this issue Jan 16, 2020
@piosok
K2InformaticsGmbH#308 Added unit test for testing behaviour of filter…
f8acd75 
… compilation for ['*'] case
piosok added a commit to piosok/imem that referenced this issue Jan 17, 2020
@piosok
K2InformaticsGmbH#308 - added specific case for skvh '*' handling in …
8aa618c 
…filter2ms
piosok added a commit to piosok/imem that referenced this issue Jan 17, 2020
@piosok
K2InformaticsGmbH#308 Updated tests according to comments
117b7aa
shamis pushed a commit that referenced this issue Feb 10, 2020
@c-bik @piosok
Skvh snap filter fix (#318)
b9d4a72 
* #308
'*' is not interpreted as wildcard becuse only symbols in list are considered wildcards.
added clause hasWild to interpret '*' as wildcard too.

* #308 Added unit test for testing behaviour of filter compilation for ['*'] case

* #308 - added specific case for skvh '*' handling in filter2ms

* #308 Updated tests according to comments

* cosmetics and refactoring

Co-authored-by: piosok <piotr.sokolowski@computaris.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piosok piosok

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

skvh filter_cluster_snapshot filters out everything for ['*'] as filter. piosok/imem
2 participants
@c-bik @piosok