The pddl-parser seems to reject empty effects without conjunctions

[rpgoldman]

This definition failed to parse:

(:ACTION DIVERGENCE
          :PARAMETERS () ; (?P ?O)
          :PRECONDITION ()
          :EFFECT ())

but this one succeeded:

(:ACTION DIVERGENCE
          :PARAMETERS () ; (?P ?O)
          :PRECONDITION ()
          :EFFECT (AND))

If I understand the syntax correctly, an empty effect as in the first example, seems to be explicitly accepted.

[guicho271828]

looks like so.

<emptyOr(x)>::=()
<emptyOr(x)>::=x
<action-def body> ::= [:precondition <emptyOr (pre-GD)>]
                      [:effect <emptyOr (effect)>]

[DerekLong101]

Yes, quite right, they should be accepted. This is an outstanding issue that I should have dealt with long ago. I will try to get on top of it and let you know! Cheers Derek

…

________________________________ From: rpgoldman <notifications@github.com> Sent: 13 September 2017 00:00:17 To: KCL-Planning/VAL Cc: Subscribed Subject: [KCL-Planning/VAL] The pddl-parser seems to reject empty effects without conjunctions (#21) This definition failed to parse: (:ACTION DIVERGENCE :PARAMETERS () ; (?P ?O) :PRECONDITION () :EFFECT ()) but this one succeeded: (:ACTION DIVERGENCE :PARAMETERS () ; (?P ?O) :PRECONDITION () :EFFECT (AND)) If I understand the syntax correctly, an empty effect as in the first example, seems to be explicitly accepted. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKCL-Planning%2FVAL%2Fissues%2F21&data=01%7C01%7Cderek.long%40kcl.ac.uk%7Ca4e5baaa810547709f8808d4fa320cf7%7C8370cf1416f34c16b83c724071654356%7C0&sdata=XYgul3t0pMTlngjZ5Aq48CwgvSjZqOCRL09DCWdYIb0%3D&reserved=0>, or mute the thread<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHSnVO1U6uIDkggt9Y0YtPDri4YYGjEJks5shw0AgaJpZM4PVXV_&data=01%7C01%7Cderek.long%40kcl.ac.uk%7Ca4e5baaa810547709f8808d4fa320cf7%7C8370cf1416f34c16b83c724071654356%7C0&sdata=7HyhY4Qm7O0%2BpXXFfXWWc9vcseUtDPtrPYJlT3XN0fw%3D&reserved=0>.

[guicho271828]

If you are struggling to take time for maintaining this software, you could consider inviting active people as the collaborators (merge/push access) so that the project keeps being healthy.

[guicho271828]

My branch now contains a fix to this issue. b047344

[guicho271828]

ping --- is this fixed?

[DerekLong101]

Thanks for the ping. I will deal with this - I am finding time to move a few things along. You could issue a pull request for your proposed fix.