Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed windows cannot be re-docked. #96

Closed
nandishnan4 opened this issue Nov 12, 2020 · 9 comments
Closed

Tabbed windows cannot be re-docked. #96

nandishnan4 opened this issue Nov 12, 2020 · 9 comments
Labels
duplicate This issue or pull request already exists

Comments

@nandishnan4
Copy link

nandishnan4 commented Nov 12, 2020

Hi Sergio,

when a widget is un-docked, it can be re-docked by clicking on the button at the right top corner. However this does not work if we have two or more widgets tabbed together before they were un-docked.

The Giff in attach explains the problem more clearly.
If you need more information, please feel free to contact.

TabbedGrpReDock

Further more, the tabbed windows are re-docked to main window and not the floating window they were previously docked to.
I expect dockwidget 2 to get docked to dockwidget 0 in this case. But both the windows get docked to MainWindow.

Please find the Giff in attach which explains the problem.
TabbedGrpReDock1

If you need any more information, please feel free to contact.

Kind Regards
Nandish

@iamsergio
Copy link
Contributor

This is #44 , not trivial to fix quickly, but on my todo list

@iamsergio iamsergio added the duplicate This issue or pull request already exists label Dec 16, 2020
@iamsergio
Copy link
Contributor

Let's continue in #44

@tlaemmlein
Copy link

@iamsergio
Do you think a workaround could be to disable the 'dock' button if the widgets are tabbed? Then it is more clear rather than have a 'clickable' button which do nothing.
Kind Regards,
Thomas

@iamsergio
Copy link
Contributor

@tlaemmlein ok I will disable the dock button

@tlaemmlein
Copy link

@iamsergio What is the current status of this issue?

@iamsergio
Copy link
Contributor

@tlaemmlein will be scheduled for March

@iamsergio iamsergio reopened this Mar 7, 2022
iamsergio added a commit that referenced this issue Mar 7, 2022
TitleBar::isFloating() was returning false, while it should
have returned true.

Fixed by making isFloating() simpler and dumb. isFloating() should
only say if it belongs to a floating window or not. It shouldn't
contain any logic about whether button should be visible or not.

There's already logic elsewhere that will hide the float button
in case there's nesting.

Fixes issue #96 and #44
@iamsergio
Copy link
Contributor

It's fixed for me now

@tlaemmlein
Copy link

@iamsergio Thank you for the fix. Can you merge the fix into the 1.5 branch? Greetings, Thomas

@iamsergio
Copy link
Contributor

Maybe it will be a 1.6 release, need to check

iamsergio added a commit that referenced this issue Jun 18, 2022
TitleBar::isFloating() was returning false, while it should
have returned true.

Fixed by making isFloating() simpler and dumb. isFloating() should
only say if it belongs to a floating window or not. It shouldn't
contain any logic about whether button should be visible or not.

There's already logic elsewhere that will hide the float button
in case there's nesting.

Fixes issue #96 and #44

(cherry-picked from commit 0099a19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants