-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabbed windows cannot be re-docked. #96
Comments
This is #44 , not trivial to fix quickly, but on my todo list |
Let's continue in #44 |
@iamsergio |
@tlaemmlein ok I will disable the dock button |
@iamsergio What is the current status of this issue? |
@tlaemmlein will be scheduled for March |
TitleBar::isFloating() was returning false, while it should have returned true. Fixed by making isFloating() simpler and dumb. isFloating() should only say if it belongs to a floating window or not. It shouldn't contain any logic about whether button should be visible or not. There's already logic elsewhere that will hide the float button in case there's nesting. Fixes issue #96 and #44
It's fixed for me now |
@iamsergio Thank you for the fix. Can you merge the fix into the 1.5 branch? Greetings, Thomas |
Maybe it will be a 1.6 release, need to check |
TitleBar::isFloating() was returning false, while it should have returned true. Fixed by making isFloating() simpler and dumb. isFloating() should only say if it belongs to a floating window or not. It shouldn't contain any logic about whether button should be visible or not. There's already logic elsewhere that will hide the float button in case there's nesting. Fixes issue #96 and #44 (cherry-picked from commit 0099a19)
Hi Sergio,
when a widget is un-docked, it can be re-docked by clicking on the button at the right top corner. However this does not work if we have two or more widgets tabbed together before they were un-docked.
The Giff in attach explains the problem more clearly.
If you need more information, please feel free to contact.
Further more, the tabbed windows are re-docked to main window and not the floating window they were previously docked to.
I expect dockwidget 2 to get docked to dockwidget 0 in this case. But both the windows get docked to MainWindow.
Please find the Giff in attach which explains the problem.

If you need any more information, please feel free to contact.
Kind Regards
Nandish
The text was updated successfully, but these errors were encountered: