Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct c++ syntax for localTypeForElement #215

Merged
merged 1 commit into from
Mar 30, 2020
Merged

correct c++ syntax for localTypeForElement #215

merged 1 commit into from
Mar 30, 2020

Conversation

anoymouserver
Copy link
Contributor

fixes #210

@dfaure-kdab dfaure-kdab merged commit 4828e67 into KDAB:master Mar 30, 2020
dfaure-kdab added a commit that referenced this pull request Mar 30, 2020
@dfaure-kdab
Revert "also correct localTypeForElement to avoid invalid characters (#…
b1b7da0 
…215)"

This reverts commit 4828e67.
@dfaure-kdab
Copy link
Member

I reverted this, it breaks many unittests.
int became Int, bool became Bool.

unittests/ihc_wsdl/wsdl_resourceinteraction.h:47:5: error: ‘Int’ does not name a type; did you mean ‘int’?
Int parameter13() const;

and many other errors like this one.

@anoymouserver
Copy link
Contributor Author

Oh, I'm sorry. I'll take a look at this tomorrow how I can make sure it only 'corrects' custom types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kdwsdl2cpp generates invalid class name
2 participants
@anoymouserver @dfaure-kdab