Skip to content

Commit

Permalink
fix: Remove dev-dependencies on cxx-qt-lib
Browse files Browse the repository at this point in the history
This was causing a duplicate build of cxx-qt-lib, which caused the file
locking issues we observed in CI.

This should also speed up the CI run for cargo_test, as it's not
building -lib twice now.

However, this doesn't yet solve the inherent issue that Cargo may run
build scripts of different configurations in parallel.
So this remains a TODO!
  • Loading branch information
LeonMatthesKDAB committed Jul 12, 2024
1 parent dc73209 commit e0eea65
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion crates/cxx-qt-macro/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ syn.workspace = true

[dev-dependencies]
cxx.workspace = true
cxx-qt-lib.workspace = true
cxx-qt.workspace = true
1 change: 0 additions & 1 deletion crates/cxx-qt/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,3 @@ qt-build-utils.workspace = true

[dev-dependencies]
cxx.workspace = true
cxx-qt-lib.workspace = true

0 comments on commit e0eea65

Please sign in to comment.