Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating a CI runner for MinGW #645

Open
4 tasks
ahayzen-kdab opened this issue Aug 1, 2023 · 3 comments
Open
4 tasks

Consider creating a CI runner for MinGW #645

ahayzen-kdab opened this issue Aug 1, 2023 · 3 comments
Labels
🔨 build system Issues related to integrating CXX-Qt into CMake/Cargo ⬆️ feature New feature or request 🙋 good first issue Good for newcomers

Comments

@ahayzen-kdab
Copy link
Collaborator

ahayzen-kdab commented Aug 1, 2023

  • Create separate CI runner for MinGW Qt5 and Qt6
  • Only enable MSVC prompt for MSVC rather than "Windows"
  • Install MinGW in the CI runner
  • Find out if the tests run correctly and fix any broken ones
@ahayzen-kdab ahayzen-kdab added ⬆️ feature New feature or request 🙋 good first issue Good for newcomers 🔨 build system Issues related to integrating CXX-Qt into CMake/Cargo labels Aug 1, 2023
@ahayzen-kdab
Copy link
Collaborator Author

@Be-ing any ideas how easy this might or might not be ?

Looks like this would need to be adjusted to be only msvc

    # Required for CMake to find Ninja
    - name: "[Windows] Set up MSVC Developer Command Prompt"
      if: runner.os == 'Windows'
      uses: seanmiddleditch/gha-setup-vsdevenv@v3

And we would need a new block here which doesn't use cl ?

          - name: Windows 2022 (MSVC) Qt6
            os: windows-2022
            qt_version: 6
            ctest_args: --exclude-regex '^(reuse_lint|cpp_clang_format|.*valgrind)$'
            exe_suffix: .exe
            qt_qpa_platform: windows
            compiler_cache_path: C:\Users\runneradmin\AppData\Local\Mozilla\sccache\cache
            cargo_dir: C:\Users\runneradmin\.cargo
            cc: cl
            cxx: cl
            # The D drive runs out of space when building dependencies with vcpkg.
            workspace: C:\cxx-qt

And we would need to install mingw from somewhere ? (would this be from vcpkg or is there a github action we can use or is it already installed?)

@Be-ing
Copy link
Contributor

Be-ing commented Aug 1, 2023

I do want to support MinGW, however, I'm a bit concerned about using 8 CI jobs on every commit 😵

@ahayzen-kdab
Copy link
Collaborator Author

@Be-ing I wonder if we only run certain runners on every commit, then have extra runners for either just main or just releases or something 🤷

I thought i had seen other projects that have some runners run initially in the pull request for each commit, then when things are approved before merging it runs all the tests - but maybe I'm dreaming :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 build system Issues related to integrating CXX-Qt into CMake/Cargo ⬆️ feature New feature or request 🙋 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants