fix "file too big" error in MinGW Debug

[jacquetc]

#625

[ahayzen-kdab]

Cool thanks! lets see what CI thinks.

And does this now mean that MinGW builds and works on Windows ? As i've then created another task #645 to create a CI runner for it, so we can ensure we don't regress :-)

[jacquetc]

Cool thanks! lets see what CI thinks.

And does this now mean that MinGW builds and works on Windows ? As i've then created another task #645 to create a CI runner for it, so we can ensure we don't regress :-)

That is a good assumption. I have still errors, but about my own code, so I can't be sure before fixing my own mess. :)

[Be-ing]

That is a good assumption. I have still errors, but about my own code, so I can't be sure before fixing my own mess. :)

Please try building the examples in this repo with MinGW so you don't have the uncertainty about your downstream code. I'd like to confirm that MinGW builds do work with this before merging.

[Be-ing]

Can you explicitly confirm this does build now with MinGW? I'm unclear if that's what you meant by the 👍 on my last comment.

[jacquetc]

Can you explicitly confirm this does build now with MinGW? I'm unclear if that's what you meant by the 👍 on my last comment.

I was only acknowledging the demand, not giving the OK

[jacquetc]

Problem while compiling cc-rs and no time tonight to debug it.

   Compiling proc-macro2 v1.0.66
   Compiling unicode-ident v1.0.11
   Compiling jobserver v0.1.26
   Compiling winapi v0.3.9
   Compiling memchr v2.5.0
   Compiling once_cell v1.18.0
   Compiling thiserror v1.0.44
   Compiling minimal-lexical v0.2.1
   Compiling cc v1.0.79
   Compiling either v1.9.0
   Compiling unicode-width v0.1.10
   Compiling itertools v0.10.5
   Compiling cxxbridge-flags v1.0.102
   Compiling unicode-segmentation v1.10.1
   Compiling scratch v1.0.7
error[E0615]: attempted to take value of method `into` on type `&String`
    --> C:\Users\cyril\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cc-1.0.79\src\lib.rs:1552:44
     |
1552 |             println!("supported: {}", flag.into);
     |                                            ^^^^ method, not a field
     |
help: use parentheses to call the method
     |
1552 |             println!("supported: {}", flag.into());
     |                                                ++

error[E0615]: attempted to take value of method `into` on type `&String`
    --> C:\Users\cyril\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cc-1.0.79\src\lib.rs:1554:53
     |
1554 |                 println!("supported flag: {}", flag.into);
     |                                                     ^^^^ method, not a field
     |
help: use parentheses to call the method
     |
1554 |                 println!("supported flag: {}", flag.into());
     |                                                         ++

For more information about this error, try `rustc --explain E0615`.
error: could not compile `cc` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

[ahayzen-kdab]

Looks like you have local changes or something broken upstream in cc, but they haven't had a release in a while.

Could try cargo update and ensure you don't have any patches.

[jacquetc]

I had first to delete the .cargo/registry and then it compiled.
Qt 6 MingGW Debug : Ok
Qt 5 MinGW Debug : Ok

[Be-ing]

Thanks for your contributions! I'm glad we have MinGW support now!!

[LeonMatthesKDAB]

@jacquetc Thank you very much for the contribution 🥳

We should probably also investigate whether we can decrease the size of these object files.
This seems like it might be contributing to the issues we're having with long compile times on the C++ side of cxx-qt-lib.
If the object files we're generating are that huge, maybe there's more code generated than we actually need.

[jacquetc]

@jacquetc Thank you very much for the contribution 🥳

We should probably also investigate whether we can decrease the size of these object files. This seems like it might be contributing to the issues we're having with long compile times on the C++ side of cxx-qt-lib. If the object files we're generating are that huge, maybe there's more code generated than we actually need.

You are welcome 😄 I fear that investigating the size is a bit too low level for my current knowledge.
Also, we must remember to update the documentation.

[LeonMatthesKDAB]

Right, don't feel obliged to continue on this issue, we can probably look into this ourselves, as the object files are likely just as big on linux. It's just something to keep in mind when we finally get around to optimizing for build times.